Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove broken MV3 perf stats #29408

Merged
merged 1 commit into from
Dec 20, 2024
Merged

chore: Remove broken MV3 perf stats #29408

merged 1 commit into from
Dec 20, 2024

Conversation

Gudahtt
Copy link
Member

@Gudahtt Gudahtt commented Dec 20, 2024

Description

Remove broken MV3 reports. These reports relied upon data from the mv3-perf-stats E2E test job, which itself relied upon the user-data-dir chromedriver setting removed in #24696. They have been broken since that PR.

These reports were very useful in prioritizing MV3 work at the time, but we haven't needed them recently.

The mv3-stats E2E test suite has also been removed (this is an older version of mv3-perf-stats that has been unused for even longer), along with the charts that were used for this report.

Open in GitHub Codespaces

Related issues

Relates to #28572

Manual testing steps

Check that the metamaskbot comment no longer has the links to these broken reports. They look like this:

  • mv3: Background Module Init Stats
  • mv3: UI Init Stats
  • mv3: Module Load Stats

Screenshots/Recordings

N/A

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Remove broken MV3 reports. These reports relied upon data from the
`mv3-perf-stats` E2E test job, which itself relied upon the
`user-data-dir` chromedriver setting removed in #24696. They have been
broken since that PR.

These reports were very useful in prioritizing MV3 work at the time,
but we haven't needed them recently.

The `mv3-stats` E2E test suite has also been removed (this is an older
version of `mv3-perf-stats` that has been unused for even longer),
along with the charts that were used for this report.
@Gudahtt Gudahtt changed the title chore: Remove broken MV3 module stats chore: Remove broken MV3 perf stats Dec 20, 2024
@metamaskbot
Copy link
Collaborator

Builds ready [18ef58a]
Page Load Metrics (1702 ± 88 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint14932276171418589
domContentLoaded14312249167018388
load14962282170218388
domInteractive236733136
backgroundConnect1298382311
firstReactRender1676422411
getState594172010
initialActions01000
loadScripts1046142912309445
setupStore76012136
uiStartup16892520192620599

@Gudahtt Gudahtt marked this pull request as ready for review December 20, 2024 21:26
@Gudahtt Gudahtt requested a review from a team as a code owner December 20, 2024 21:26
Copy link
Contributor

@desi desi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! LGTM!

@hjetpoluru hjetpoluru self-requested a review December 20, 2024 23:14
Copy link
Contributor

@hjetpoluru hjetpoluru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and here is the screenshot of the removed items
Screenshot 2024-12-20 at 6 12 11 PM

@Gudahtt Gudahtt added this pull request to the merge queue Dec 20, 2024
Merged via the queue into main with commit 57d564d Dec 20, 2024
93 checks passed
@Gudahtt Gudahtt deleted the remove-broken-status branch December 20, 2024 23:51
@github-actions github-actions bot locked and limited conversation to collaborators Dec 20, 2024
@metamaskbot metamaskbot added the release-12.11.0 Issue or pull request that will be included in release 12.11.0 label Dec 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.11.0 Issue or pull request that will be included in release 12.11.0 team-extension-platform team-wallet-framework
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants